This repository was archived by the owner on Oct 2, 2023. It is now read-only.
Improve startup state handling #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losfair
force-pushed
the
cherry-pick/improve-startup-state
branch
from
2da9f3d to
a02f1e4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like a remote denial-of-service (via stack overflow) on the server can be triggered by continuously sending
SSLRequest, sincehandleSSLRequestMessagerecursively callsserveConnStartupand the call fromserveConnStartuptohandleSSLRequestMessageisn't a tail call.This PR introduces a
startupStatetype for managing the lifecycle of the startup phase.